Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ILMBASE_HAVE_CONTROL_REGISTER_SUPPORT to a private header #357

Closed
malaterre opened this issue Nov 7, 2018 · 2 comments
Closed

Move ILMBASE_HAVE_CONTROL_REGISTER_SUPPORT to a private header #357

malaterre opened this issue Nov 7, 2018 · 2 comments
Labels
Bug A bug in the source code Build A problem with building or installing the library.

Comments

@malaterre
Copy link

Currently ILMBASE_HAVE_CONTROL_REGISTER_SUPPORT is being tested and then defined in a public header that will get installed:

config/IlmBaseConfig.h.in:#undef ILMBASE_HAVE_CONTROL_REGISTER_SUPPORT

This is an issue for us at least in the context of cross compiling since now the header on -say- armhf and amd64 will be different.

Would it be possible to move this define to some kind of private header which wont be installed as part of the standard installation. Another possibility is simply to pass this definition on the command line using -D. This way this is not explicitly visible in the header file.

@meshula
Copy link
Contributor

meshula commented Nov 9, 2018

This flag exists only for the implementation of

void setFpExceptionHandler (FpExceptionHandler handler);

I agree that this flag should be hidden within the implementation.

@cary-ilm cary-ilm added Build A problem with building or installing the library. C++ labels Jun 13, 2019
@cary-ilm cary-ilm added Bug A bug in the source code TODO labels Jun 26, 2019
@cary-ilm cary-ilm added this to the Needs Attention milestone Jun 29, 2019
@kdt3rd kdt3rd mentioned this issue Jul 11, 2019
@kdt3rd
Copy link
Contributor

kdt3rd commented Jul 17, 2019

This has been implemented, there are now two auto-generated headers, one for internal things, and one for the public namespace configuration, etc.

@kdt3rd kdt3rd closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the source code Build A problem with building or installing the library.
Projects
None yet
Development

No branches or pull requests

4 participants