compiling tests on windows fails

[meshula]

testCompression.cpp needs #include to resolve the std::min macro.

(I'm still waiting on EasyCLA)

[cary-ilm]

Can you point to the log for the failed build? I'm happy to fix it but I'm not seeing it, and I also don't see where std::min() is called in testCompression.cpp.

[meshula]

I wrote that too late at night, should have dropped the messages in. Also, it's max, not min... Also I see the markdown ate my message.

#include <algorithm>

is what that note was supposed to read.

C:\Projects\openexr\src\test\OpenEXRTest\testCompression.cpp(470,59): error C3861: 'max': identifier not found [C:\Projects\openexr\build\src\test\OpenEXRTest\OpenEXRTest.vcxproj]
C:\Projects\openexr\src\test\OpenEXRTest\testCompression.cpp(470,49): error C3861: 'max': identifier not found [C:\Projects\openexr\build\src\test\OpenEXRTest\OpenEXRTest.vcxproj]

[cary-ilm]

#937 should hopefully fix it. It's std::max is in , right?

Can do you know why you're getting this error when our Windows CI build succeeds?

[meshula]

I tested 937 just now. limits is insufficient, I had to add algorithm.

I haven't had time to dig into why the CI succeeds. I thought I would look into the other issue where Windows build failures were reported, and discovered that I saw a few blocking issues locally, which I've reported. My best theory is that I have a more recent Visual Studio than the CI runs.

There could be further issues, I won't know until the Imath install prefix error is resolved.

[cary-ilm]

I just pushed a commit to #937 to add #include , give it another poke.

[meshula]

Yes, that works :)