Set OPENEXR_VERSION from OpenEXR_VERSION variables #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OPENEXR_VERSION_RELEASE_TYPE replaces OPENEXR_VERSION_EXTRA * OPENEXR_VERSION_RELEASE_TYPE is used only to form OPENEXR_PACKAGE_NAME Signed-off-by: Cary Phillips <cary@ilm.com>
lgritz
approved these changes
May 20, 2021
|
Dammit, I just can't seem to keep from suggesting dangerous things. This breaks the generation of OpenEXRConfig.h. Totally my fault, I should have grepped for OPENEXR_VERSION before we changed it. I will post a fix shortly. |
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
May 30, 2021
…undation#1025) * OPENEXR_VERSION_RELEASE_TYPE replaces OPENEXR_VERSION_EXTRA * OPENEXR_VERSION_RELEASE_TYPE is used only to form OPENEXR_PACKAGE_NAME Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Jun 1, 2021
* OPENEXR_VERSION_RELEASE_TYPE replaces OPENEXR_VERSION_EXTRA * OPENEXR_VERSION_RELEASE_TYPE is used only to form OPENEXR_PACKAGE_NAME Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEXR_VERSION_RELEASE_TYPE replaces OPENEXR_VERSION_EXTRA
OPENEXR_VERSION_RELEASE_TYPE is used only to form OPENEXR_PACKAGE_NAME
Signed-off-by: Cary Phillips cary@ilm.com