Add validate_openexr_libs.sh to validate .so symlinks #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoked by the ci, but also helpful as a standalone in validating new releases. Validates the pkg-config and library symlinks. Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
kdt3rd
reviewed
Jun 24, 2021
|
|
||
| echo -e '#include <ImfHeader.h>\n#include <OpenEXRConfig.h>\n#include <stdio.h>\nint main() { puts(OPENEXR_PACKAGE_STRING); Imf::Header h; return 0; }' > $VALIDATE_CPP | ||
|
|
||
| g++ $CXX_FLAGS $VALIDATE_CPP -o $VALIDATE_BIN $LD_FLAGS |
There was a problem hiding this comment.
will this work on the build matrix variants where we are using clang? (not sure if docker will put a gcc in there)
There was a problem hiding this comment.
It probably does make sense to use the same compiler as the build matrix, I'll look into a way to pass that in, although it works for now.
We recently had problems with installing broken symlinks and pkg-configs, so this is just a check in the ci to ensure that bug doesn't creep back in, not intended as a general utility or part of the test suite.
kdt3rd
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoked by the ci, but also helpful as a standalone in validating new releases. Validates the pkg-config and library symlinks.