Add additional test to ensure correct detection for threads #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would appear cmake doesn't preserve the prefer-pthread argument in the find dependency call, also, ensure cmake is happy with the boolean check. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
|
This will address #1121 |
|
In the PR title, did you mean "additional test" instead of "additional text"? |
cary-ilm
changed the title
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Sep 23, 2021
…oftwareFoundation#1151) It would appear cmake doesn't preserve the prefer-pthread argument in the find dependency call, also, ensure cmake is happy with the boolean check. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Sep 29, 2021
It would appear cmake doesn't preserve the prefer-pthread argument in the find dependency call, also, ensure cmake is happy with the boolean check. Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear cmake doesn't preserve the prefer-pthread argument in
the generated find dependency call, also, ensure cmake is happy with the boolean
check.
Signed-off-by: Kimball Thurston kdt3rd@gmail.com