use std::abs in chromaticity sanity tests (fixes #1177) #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#1177) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
lgritz
approved these changes
Oct 12, 2021
|
LGTM, too. Other files that use abs() have "using namespace std", although EnvmapImage.cpp and ImfFramesPerSecond.cpp seem to be picking up abs() from ImathFun.h, which should probably be deprecated in favor of std::abs(). |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Oct 14, 2021
…ation#1177) (AcademySoftwareFoundation#1178) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abs()on older compilers resolves to integer only method. Explicitly usestd::abs()on each occurrence to force use of floating-point overloadSigned-off-by: Peter Hillman peterh@wetafx.co.nz