Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script so auto-build of imath uses the new branch name #1228

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

lgritz
Copy link
Contributor

@lgritz lgritz commented Feb 12, 2022

Signed-off-by: Larry Gritz lg@larrygritz.com

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz lgritz requested a review from cary-ilm February 12, 2022 20:16
@cary-ilm
Copy link
Member

Thanks, I'm about to submit a PR that updates everything else as well, just confirming the build, and waiting for the checks.

@lgritz
Copy link
Contributor Author

lgritz commented Feb 12, 2022

I'm not totally sure I understand. Do you want me to merge this when the checks are finished? Or are you saying that these changes are already incorporated into another pending PR?

@kdt3rd
Copy link
Contributor

kdt3rd commented Feb 12, 2022

fyi: I fixed the windows build earlier, clang-format had sort includes turne on, which moves windows.h around :(

@cary-ilm
Copy link
Member

Fine to merge this when the checks pass.

@cary-ilm cary-ilm merged commit 767b341 into AcademySoftwareFoundation:main Feb 12, 2022
@lgritz lgritz deleted the lg-build branch March 20, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants