Reduce memory in testDeepScanLineBasic #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
|
Thanks for figuring out the valgrind failure! This sounds like a good situation for a build-time setting. The fuzz tests could set it large, but valgrind can set it low. What valgrind is testing for shouldn't depend on memory size, so small should be fine. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…ion#1347) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valgrind analysis test is failing due to excessive memory requirements on large deep images. Reducing the image size should get the test through, so will do for now, though this is less effective at testing for issues caused with large images.
Maybe there should be macro that could be defined to limit memory consumption of the tests for such situations.