Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent integer overflows in file exrmultipart.cpp #1681

Merged
merged 1 commit into from Mar 19, 2024
Merged

prevent integer overflows in file exrmultipart.cpp #1681

merged 1 commit into from Mar 19, 2024

Conversation

xiaoxiaoafeifei
Copy link
Contributor

Fix #1680

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 19, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xiaoxiaoafeifei (cec1901)

@xiaoxiaoafeifei
prevent integer overflows in file exrmultipart.cpp
cec1901 
Signed-off-by: ZhaiLiangliang <zhailiangliang@loongson.cn>
peterhillman
peterhillman approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@peterhillman peterhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix

@cary-ilm
Copy link
Member

Thanks!

@cary-ilm cary-ilm merged commit 7aa89e1 into AcademySoftwareFoundation:main Mar 19, 2024
28 checks passed
@risicle
Copy link

risicle commented Apr 27, 2024

Might we get a 3.2.5 release including this? Glancing briefly at the way these variables are used, I'd be surprised if overflowing them couldn't lead to an OOB memory access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhillman peterhillman peterhillman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An integer overflow in file exrmultipart.cpp
4 participants
@xiaoxiaoafeifei @cary-ilm @risicle @peterhillman