Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #95, compilation issue with mingw #448

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Jul 17, 2019

The tree now compiles using mingw to compile, tested by cross compiling
for windows from linux

Signed-off-by: Kimball Thurston kdt3rd@gmail.com

The tree now compiles using mingw to compile, tested by cross compiling
for windows from linux

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm no expert here. If it compiles on the target platforms and the tests pass, the code looks cleaner.

@kdt3rd kdt3rd merged commit 2cf0560 into AcademySoftwareFoundation:master Jul 17, 2019
@cary-ilm cary-ilm added this to the v2.4.0 milestone Aug 10, 2019
@kdt3rd kdt3rd deleted the fix_95 branch February 12, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants