Fix int32 overflow bugs with deep images #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 32k x 32k image * 8 byte pointers leads to an overflow when trying to find the sample count of a deep pixel. Signed-off-by: Larry Gritz <lg@imageworks.com>
cary-ilm
reviewed
Oct 18, 2019
| @@ -99,7 +99,7 @@ inline | |||
| int& | |||
| sampleCount(char* base, int xStride, int yStride, int x, int y) | |||
| { | |||
| char* ptr = base + y * yStride + x * xStride; | |||
| char* ptr = base + y * ptrdiff_t(yStride) + x * ptrdiff_t(xStride); | |||
There was a problem hiding this comment.
Wouldn't it be better to change the type of the function arguments to ptrdiff_t?
There was a problem hiding this comment.
I wanted something that could be easily folded into a 2.4.1 (or even backported earlier) without changing any function signatures. I can't wait until 2021 for this fix to proliferate into software that's widely used.
There was a problem hiding this comment.
But maybe a TODO item to scrub the whole API for places that should be upgraded from 32 to 64 bit ints next time we are willing to have very-breaking changes.
|
Shall I merge this? |
cary-ilm
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 32k x 32k image * 8 byte pointers leads to an overflow when trying
to find the sample count of a deep pixel.
Signed-off-by: Larry Gritz lg@imageworks.com