Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reloading broken files with IlmImfFuzzTest #662

Merged

Conversation

peterhillman
Copy link
Contributor

This extends each of the IlmImfFuzzTest tools to accept an EXR file to load.
E.g. ./IlmImfFuzzTest testFuzzScanLines /var/tmp/imf_test_scanline_file_fuzz_broken.exr
This allows quicker debugging where a regular IlmImfFuzzTest run errors

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth a comment explaining the file argument: normally, the test runs on data generated on the fly, but the argument makes it possible to run the test on externally provided data, useful in debugging. Right?

@peterhillman
Copy link
Contributor Author

I will add some command-line help to IlmImfFuzzTest and IlmImfTest to explain how to use them and update the PR

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@cary-ilm cary-ilm merged commit a0e84f6 into AcademySoftwareFoundation:master Feb 20, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants