Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent invalid values in LineOrder enum #795

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

cary-ilm
Copy link
Member

This avoids the 'undefined behavior' sanitizer warning when reading files with invalid LineOrder attribute values. The behavior is unchanged, since sanityCheck() throws an exception with invalid LineOrder values.

Addresses https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24333

Signed-off-by: Cary Phillips cary@ilm.com

Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@peterhillman peterhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit bdc310a into AcademySoftwareFoundation:master Jul 24, 2020
@cary-ilm cary-ilm deleted the lineorder-fix branch July 24, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants