Fixes for recent Imath deprecations #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLT_MAX was erroring for being undefined, because of some removals of includes deep in Imath that we inadvertently depended on instead of including <limits.h> here in OpenEXR. But that should be replaced by std::numeric_limits<float>::max() anyway, in modern C++ style. Also, fix some warnings due to Imath::Math<> having been marked as deprecated and now std:: for certain math functions is preferred. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Failing Windows CI. Grrrr... |
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLT_MAX was erroring for being undefined, because of some removals of
includes deep in Imath that we inadvertently depended on instead of
including
<limits.h>here in OpenEXR. But that should be replaced bystd::numeric_limits<float>::max()anyway, in modern C++ style.Also, fix some warnings due to
Imath::Math<>having been marked asdeprecated and now
std::for certain math functions is preferred.Signed-off-by: Larry Gritz lg@larrygritz.com