Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NO_COMPRESSION in OpenEXRTest/testBackwardCompatibility #916

Conversation

peterhillman
Copy link
Contributor

Following discussion in #876, use NO_COMPRESSION in Backwards Compatibility test. zlib is not guaranteed to produce binary-identical compressed data, so different builds of the OpenEXR library will not produce binary-identical compressed files when the default ZIP_COMPRESSION is used. NO_COMPRESSION should produce binary identical files.

The test files were recreated using the OpenEXR-1.7.1 library.

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 25a11d9 into AcademySoftwareFoundation:master Feb 6, 2021
@peterhillman peterhillman deleted the uncompressed_backward_compatibility_test branch February 6, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants