exrcheck: check for tilesize in reduceMemory mode #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=30605
Extend #895 to bypass TiledInputFile and DeepTiledInputFile test on files which contain large tiles. The tests are also bypassed on files where the MultiPartInputFile constructor fails.
Excessively large tiles cause the constructor to allocate large amounts of memory to decode the file. The MultiPartInputFile API constructor does not allocate such memory up-front, so the calling code can check the header attributes to check that tile/scanline sizes are reasonable before calling InputPart or TiledInputPart to allocate memory and read the image.
Header::setMaxImageSize and Header::setMaxTileSize can also be used to abort constructors early before memory is allocated.