Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exrcheck: fix handling xSampling when computating slice base #932

Conversation

peterhillman
Copy link
Contributor

Fix regression from #930: missing parentheses caused the Slice 'base' to be computed incorrectly whenever dataWindow.min.x is not a multiple of xSampling.

Addresses
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31291
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31293

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit d51c77e into AcademySoftwareFoundation:master Feb 24, 2021
@peterhillman peterhillman deleted the exrcheck_fix_sampling_rounding branch February 24, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants