-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for HalfGrid and ComputeType #1787
Open
ghurstunither
wants to merge
3
commits into
AcademySoftwareFoundation:master
Choose a base branch
from
ghurstunither:feature/HalfGrid_Support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Copyright Contributors to the OpenVDB Project | ||
// SPDX-License-Identifier: MPL-2.0 | ||
|
||
#ifndef OPENVDB_HALFDECL_HAS_BEEN_INCLUDED | ||
#define OPENVDB_HALFDECL_HAS_BEEN_INCLUDED | ||
|
||
#ifdef OPENVDB_USE_IMATH_HALF | ||
#ifdef OPENVDB_IMATH_VERSION | ||
#include <Imath/half.h> | ||
#else | ||
#include <OpenEXR/half.h> | ||
#endif | ||
namespace openvdb { | ||
OPENVDB_USE_VERSION_NAMESPACE | ||
namespace OPENVDB_VERSION_NAME { | ||
namespace math { | ||
using half = half; | ||
}}} | ||
#else | ||
#include <openvdb/math/Half.h> | ||
namespace openvdb { | ||
OPENVDB_USE_VERSION_NAMESPACE | ||
namespace OPENVDB_VERSION_NAME { | ||
namespace math { | ||
using half = internal::half; | ||
}}} | ||
#endif | ||
|
||
|
||
#endif // OPENVDB_HALFDECL_HAS_BEEN_INCLUDED |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should match what the code does. But I think in this case, the comment is right.
ValueType
reflects the payload stored in the leaf nodes and in the background value. The requirement for a level-set is for these two things to be floating point.