-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ImportError" exception raised while using "rez-gui" in Python 3. #848
Comments
So there are at least a few places where it will break on Python 3: https://github.com/nerdvegas/rez/search?q=import+StringIO&unscoped_q=import+StringIO Everytime |
Python 3 is fully supported in rez, but rez-gui hasn't been well tested.
Coverage elsewhere is good due to the unit tests.
Cheers
A
…On Thu, Feb 6, 2020 at 1:01 PM Thomas Mansencal ***@***.***> wrote:
Hi,
I'm testing Rez with Python 3 and a StringIO import in
rezgui\dialogs\ResolveDialog.py raises an ImportError exception:
C:\Users\thomas>rez-gui
Traceback (most recent call last):
File "C:\Program Files\Python37\Lib\runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "C:\Program Files\Python37\Lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "C:\Program Files\rez\Scripts\rez\rez-gui.exe\__main__.py", line 7, in <module>
File "c:\progra~1\rez\lib\site-packages\rez\cli\_entry_points.py", line 159, in run_rez_gui
return run("gui")
File "c:\progra~1\rez\lib\site-packages\rez\cli\_main.py", line 152, in run
returncode = run_cmd()
File "c:\progra~1\rez\lib\site-packages\rez\cli\_main.py", line 144, in run_cmd
return opts.func(opts, opts.parser, extra_arg_groups)
File "c:\progra~1\rez\lib\site-packages\rez\cli\gui.py", line 20, in command
from rezgui.app import run
File "c:\progra~1\rez\lib\site-packages\rezgui\app.py", line 2, in <module>
from rezgui.windows.MainWindow import MainWindow
File "c:\progra~1\rez\lib\site-packages\rezgui\windows\MainWindow.py", line 5, in <module>
from rezgui.windows.ContextSubWindow import ContextSubWindow
File "c:\progra~1\rez\lib\site-packages\rezgui\windows\ContextSubWindow.py", line 3, in <module>
from rezgui.widgets.ContextManagerWidget import ContextManagerWidget
File "c:\progra~1\rez\lib\site-packages\rezgui\widgets\ContextManagerWidget.py", line 11, in <module>
from rezgui.dialogs.ResolveDialog import ResolveDialog
File "c:\progra~1\rez\lib\site-packages\rezgui\dialogs\ResolveDialog.py", line 11, in <module>
import StringIO
ModuleNotFoundError: No module named 'StringIO'
Leads me to the following: What is the status with Python 3 support?
Cheers,
Thomas
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#848>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOUSURHQ3S3GJ2HVMLSXDRBNVQRANCNFSM4KQVEXBA>
.
|
Hi @nerdvegas, As per my PR (just above) support is not full-full, the plugin manager will break when an exception is raised while loading a plugin. Might need some more coverage in that particular block! Cheers, Thomas |
To be fair, our actual coverage is quite weak and is an area where we need to improve. I'm hoping to get back on working on rez this week-end and I'll see if I can push my work on pytest. Once that's done, it's going to be easier (I hope) to improve our test suite). |
Ah that one fell through the gaps, cheers.
…On Thu, Feb 6, 2020 at 1:27 PM Thomas Mansencal ***@***.***> wrote:
Hi @nerdvegas <https://github.com/nerdvegas>,
As per my PR (just above) support is not full-full :D, the plugin manager
will break when an exception is raised while loading a plugin. Might need
some more coverage here!
Cheers,
Thomas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#848>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOUSRT7O4NH2ZDOTRAWK3RBNYRLANCNFSM4KQVEXBA>
.
|
No problems should be fixed by #850 ;) |
Hi,
I'm testing Rez with Python 3 and a StringIO import in
rezgui\dialogs\ResolveDialog.py
raises anImportError
exception:Leads me to the following: What is the status with Python 3 support?
Cheers,
Thomas
The text was updated successfully, but these errors were encountered: