Use ExitReason::Revert instead of ExitReason::Error #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
+ Coverage 72.30% 73.80% +1.50%
==========================================
Files 171 174 +3
Lines 18730 20113 +1383
==========================================
+ Hits 13542 14845 +1303
- Misses 5188 5268 +80
Continue to review full report at Codecov.
|
xlc
reviewed
Jan 12, 2022
xlc
approved these changes
Jan 12, 2022
syan095
pushed a commit
that referenced
this pull request
Jan 13, 2022
* origin/master: (53 commits) add new audit report Use ExitReason::Revert instead of ExitReason::Error (#1772) Claim Account to use Eip-712 (#1755) Benchmark evm (#1674) support evm create rpc and allow H160 default (#1771) Update template files license header. (#1770) Fix collect_fee (#1766) handle nonce for eth tx (#1707) updated to the ORML's test coverage file (#1760) rm runtime upgrade (#1757) Happy new year 2022. (#1761) Excluded some files from test coverage (#1759) XCM: add deposit error handler for multi-currency adapter. (#1756) update stable asset (#1758) Fix test coverage for acala (#1590) Fix collect_fee (#1754) Update HEADER-GPL3 Update extrinsic-ordering-check-from-bin.yml (#1752) Update HEADER-GPL3 bump version (#1751) ...
ermalkaleci
added a commit
that referenced
this pull request
Jan 17, 2022
This reverts commit a43acda.
Merged
xlc
pushed a commit
that referenced
this pull request
Jan 25, 2022
* setup evm-tests * Revert "Use ExitReason::Revert instead of ExitReason::Error (#1772)" This reverts commit a43acda. * update evm-tests commit hash * clippy * fix warnings * cleanup * fix selfdestruct remaining balance * check if address exists only on evm-tests * add block_coinbase to vicinity * update vicinity * fix test * update evm-tests * make vicinity coinbase, gas_limit and difficulty optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1767