Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage for acala #1590

Merged
merged 63 commits into from
Jan 7, 2022
Merged

Fix test coverage for acala #1590

merged 63 commits into from
Jan 7, 2022

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Nov 4, 2021

Closes: #1506

Fixed test coverage script
Excluded modules that are not useful and are causing errors.
Modules excluded are:
/nodes/*
/primitives
/runtime/*

Roy Yang added 20 commits November 10, 2021 14:20
* origin/master:
  nuts finance bumo (#1602)
  update srtool 1.56.1, subwasm 0.15.0 (#1599)

# Conflicts:
#	ecosystem-modules/stable-asset
* origin/master: (102 commits)
  Fix collect_fee (#1754)
  Update HEADER-GPL3
  Update extrinsic-ordering-check-from-bin.yml (#1752)
  Update HEADER-GPL3
  bump version (#1751)
  Remove homa-lite from karura runtime (#1744)
  off-by-one (#1747)
  Revert "simulate exchange rate (#1742)" (#1746)
  simulate exchange rate (#1742)
  bump version (#1743)
  refactor homa (#1648)
  Update stable asset (#1741)
  add more info to events (#1740)
  Fix mandala swap path error (#1736)
  update stable asset (#1738)
  remove unnecessary code (#1735)
  fix currency id testing (#1733)
  rework fee payment (#1687)
  Add Deposit for Setting Alternative Fee Swap Path (#1730)
  Add register_erc20_asset and update_erc20_asset (#1731)
  ...

# Conflicts:
#	.github/workflows/coverage.yml.disabled
#	Cargo.lock
#	Cargo.toml
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1590 (84fc3fb) into master (6c7f819) will increase coverage by 4.89%.
The diff coverage is 75.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   66.91%   71.81%   +4.89%     
==========================================
  Files         224      223       -1     
  Lines       19764    21992    +2228     
==========================================
+ Hits        13226    15794    +2568     
+ Misses       6538     6198     -340     
Impacted Files Coverage Δ
ecosystem-modules/compound-cash/src/lib.rs 0.00% <0.00%> (-7.15%) ⬇️
ecosystem-modules/compound-cash/src/mock.rs 100.00% <ø> (ø)
ecosystem-modules/ren/renvm-bridge/src/mock.rs 60.00% <0.00%> (+10.00%) ⬆️
inspect/src/lib.rs 0.00% <ø> (-35.78%) ⬇️
modules/asset-registry/src/weights.rs 0.00% <0.00%> (ø)
modules/cdp-treasury/src/weights.rs 0.00% <0.00%> (ø)
modules/collator-selection/src/mock.rs 94.59% <0.00%> (+0.15%) ⬆️
modules/currencies/src/weights.rs 0.00% <0.00%> (ø)
modules/dex/src/mock.rs 100.00% <ø> (+7.89%) ⬆️
modules/dex/src/weights.rs 0.00% <0.00%> (ø)
... and 328 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e0d02...84fc3fb. Read the comment docs.

@syan095 syan095 marked this pull request as ready for review January 7, 2022 05:54
@syan095 syan095 requested review from xlc and zjb0807 January 7, 2022 05:55
@xlc
Copy link
Member

xlc commented Jan 7, 2022

can you delete the coverage.yml.disabled file

@xlc xlc merged commit 84bd208 into master Jan 7, 2022
@xlc xlc deleted the fix/test-coverage branch January 7, 2022 22:21
syan095 pushed a commit that referenced this pull request Jan 13, 2022
* origin/master: (53 commits)
  add new audit report
  Use ExitReason::Revert instead of ExitReason::Error (#1772)
  Claim Account to use Eip-712 (#1755)
  Benchmark evm (#1674)
  support evm create rpc and allow H160 default (#1771)
  Update template files license header. (#1770)
  Fix collect_fee (#1766)
  handle nonce for eth tx (#1707)
  updated to the ORML's test coverage file (#1760)
  rm runtime upgrade (#1757)
  Happy new year 2022. (#1761)
  Excluded some files from test coverage (#1759)
  XCM: add deposit error handler for multi-currency adapter. (#1756)
  update stable asset (#1758)
  Fix test coverage for acala (#1590)
  Fix collect_fee (#1754)
  Update HEADER-GPL3
  Update extrinsic-ordering-check-from-bin.yml (#1752)
  Update HEADER-GPL3
  bump version (#1751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix & Restore code coverage
3 participants