Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add warning not to put git repos into onedrive folder / CSCLSROZ-522 #78

Closed
3 of 6 tasks
JoernBerkefeld opened this issue Jul 30, 2021 · 1 comment · Fixed by #1063 or #1023
Closed
3 of 6 tasks
Labels
chore Jira issue-type "Task" documentation Improvements or additions to documentation e/IDE EPIC
Milestone

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jul 30, 2021

run check on

  • mcdev init
  • mcdev upgrade
  • mcdev join

check if project folder in which one of the above commands is run is potentially a synchronized folder - that would reduce performance together with git. print Util.logger.warn() message but allow to proceed

check with uncle google if there is a way to really find out if a folder is synchronized via

  • onedrive
  • dropbox
  • google drive
  • windows desktop folder
  • windows documents folder
  • iCloud = CloudDocs folder

update (2023-08):
I noticed that process.env includes the path of onedrive folders. It also includes the standard user folder which we should exclude because below that there will be the documents & desktop folder.

process.env = {
    "OneDrive": "C:\\Users\\joern.berkefeld\\OneDrive - Accenture",
    "OneDriveCommercial": "C:\\Users\\joern.berkefeld\\OneDrive - Accenture",
    "OneDriveConsumer": "C:\\Users\\joern.berkefeld\\OneDrive",
...
    "USERPROFILE": "C:\\Users\\joern.berkefeld",
}
@JoernBerkefeld JoernBerkefeld added documentation Improvements or additions to documentation e/IDE EPIC chore Jira issue-type "Task" labels Jul 30, 2021
@JoernBerkefeld JoernBerkefeld added this to the 3.2.0 milestone Jul 30, 2021
@JoernBerkefeld JoernBerkefeld modified the milestones: 3.2.0, 3.3.0, 3.4.0 Feb 21, 2022
tuliodnw pushed a commit that referenced this issue Jul 25, 2022
… git repo contains words found on cloud services
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.6.0 , 5.3.0 Aug 1, 2023
@JoernBerkefeld JoernBerkefeld linked a pull request Aug 1, 2023 that will close this issue
4 tasks
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.3.0, 5.2.0 Aug 1, 2023
JoernBerkefeld added a commit that referenced this issue Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Closed by #1063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Jira issue-type "Task" documentation Improvements or additions to documentation e/IDE EPIC
Projects
None yet
2 participants