Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/78 add warning not to put git repos into onedrive folder #393

Closed

Conversation

tuliodnw
Copy link

@tuliodnw tuliodnw commented Jul 25, 2022

PR details

What is the purpose of this pull request? (put an "X" next to an item)

Please delete options that are not relevant.

  • Other, please explain:

What changes did you make? (Give an overview)

there is no easy way to see if folder is being backed up,
i retrieve the absolute path to the git repo and then scan the path for words used in the cloud services('onedrive','google drive'...), in case a word is found a warning is presented to the user

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • ESLint & Prettier are not outputting errors or warnings

dependabot bot and others added 9 commits July 18, 2022 21:40
Bumps [npm-check](https://github.com/dylang/npm-check) from 5.9.2 to 6.0.1.
- [Release notes](https://github.com/dylang/npm-check/releases)
- [Commits](dylang/npm-check@v5.9.2...v6.0.1)

---
updated-dependencies:
- dependency-name: npm-check
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…p/npm-check-6.0.1

Bump npm-check from 5.9.2 to 6.0.1
Bumps [prettier-plugin-sql](https://github.com/un-ts/prettier) from 0.8.3 to 0.10.0.
- [Release notes](https://github.com/un-ts/prettier/releases)
- [Changelog](https://github.com/un-ts/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/un-ts/prettier/compare/prettier-plugin-sql@0.8.3...prettier-plugin-sql@0.10.0)

---
updated-dependencies:
- dependency-name: prettier-plugin-sql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 10.0.5 to 10.1.0.
- [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases)
- [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md)
- [Commits](lo1tuma/eslint-plugin-mocha@10.0.5...10.1.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…p/prettier-plugin-sql-0.10.0

Bump prettier-plugin-sql from 0.8.3 to 0.10.0
…p/eslint-plugin-mocha-10.1.0

Bump eslint-plugin-mocha from 10.0.5 to 10.1.0
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 43.0.0 to 43.0.2.
- [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases)
- [Commits](sindresorhus/eslint-plugin-unicorn@v43.0.0...v43.0.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-unicorn
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…p/eslint-plugin-unicorn-43.0.2

Bump eslint-plugin-unicorn from 43.0.0 to 43.0.2
… git repo contains words found on cloud services
@JoernBerkefeld
Copy link
Contributor

Tried path.resolve? That's part of nodejs and hence not an additional dependency

https://stackoverflow.com/a/42600768

Also, I think there was __dirname?

@tuliodnw
Copy link
Author

tuliodnw commented Aug 3, 2022

Tried path.resolve? That's part of nodejs and hence not an additional dependency
i did use path.resolve, i expressed myself incorrectly, i didn't use any new dependency.

@JoernBerkefeld JoernBerkefeld added the chore Jira issue-type "Task" label Oct 9, 2022
@JoernBerkefeld JoernBerkefeld marked this pull request as draft December 7, 2022 18:20
@JoernBerkefeld JoernBerkefeld linked an issue Aug 1, 2023 that may be closed by this pull request
6 tasks
@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Aug 1, 2023
@JoernBerkefeld JoernBerkefeld deleted the 78-Add-warning-not-to-put-git-repos-into-onedrive-folder branch August 1, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Jira issue-type "Task"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add warning not to put git repos into onedrive folder / CSCLSROZ-522
3 participants