Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Refactor Create Package #746

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Oct 29, 2021

Create Package has been untouched over a period and lot of cruft has set in. This is one of
the first many attempts, to clean the codebase

  • Move files to package module
  • refactor(create-package): refactor the create package stack

azlam-abdulsalam added 3 commits October 25, 2021 11:48
Create Package has been untouched over a period of time and lot of cruft has set in. This is one of
the first many attempts, to clean the codebase
@azlam-abdulsalam azlam-abdulsalam changed the title refactor/create package Refactor Create Package Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #746 (1028567) into develop (1aef0c8) will increase coverage by 0.21%.
The diff coverage is 68.29%.

❗ Current head 1028567 differs from pull request most recent head 687255d. Consider uploading reports for the commit 687255d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
+ Coverage    64.59%   64.81%   +0.21%     
===========================================
  Files           44       44              
  Lines         1466     1475       +9     
  Branches       264      268       +4     
===========================================
+ Hits           947      956       +9     
  Misses         519      519              
Impacted Files Coverage Δ
.../core/src/sfdxwrappers/ConvertSourceToMDAPIImpl.ts 83.78% <ø> (ø)
packages/core/src/package/PackageManifest.ts 74.50% <66.66%> (+5.46%) ⬆️
packages/core/src/package/SFPPackage.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5cb28b...687255d. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 5a72791 into develop Nov 2, 2021
@azlam-abdulsalam azlam-abdulsalam deleted the refactor/create-package branch November 2, 2021 13:28
@azlam-abdulsalam azlam-abdulsalam added this to the Release - November 21 milestone Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants