Install.sh should not fail inside activated environment #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrohmann
force-pushed
the
martind/install-sh-inside-env-175600566
branch
from
9157b8e
to
7e8be7a
Compare
Naatan
requested changes
Nov 5, 2020
mdrohmann
force-pushed
the
martind/install-sh-inside-env-175600566
branch
from
2c7629a
to
291589b
Compare
Naatan
requested changes
Nov 6, 2020
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
Naatan
previously approved these changes
Nov 6, 2020
…inside-env-175600566
Naatan
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was that the install scripts called
state export config --filter=dir.Whether needed or not (
state export configdoes not need it), we are alwaystrying to open a project file, and in an activated environment it first tries
to resolve the project file from the environment variable
ACTIVESTATE_PROJECTand fails with the "corrupted environment" error that bubbled up in the installation scripts - if that file does not exist.
This PR changes that behavior and attempts other ways to resolve a project file
(from working directory and the default directory)
https://www.pivotaltracker.com/story/show/175600566