Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add activiti-core-dependencies-tests module #2199

Merged
merged 5 commits into from
Nov 26, 2018

Conversation

igdianov
Copy link
Contributor

@igdianov igdianov commented Nov 23, 2018

This PR proposes to add dependency convergence tests for external activiti-api and activiti-core-common dependencies as part of #2198.

Also, added same parent version convergence test as part of #2200

It also fixes Maven-deploy-plugin configuration to follow best practice for deploying multi-module project at the end. (See #2172)

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #2199 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2199      +/-   ##
=============================================
- Coverage       61.2%   61.19%   -0.01%     
  Complexity      1523     1523              
=============================================
  Files           1125     1125              
  Lines          39950    39950              
  Branches        5814     5814              
=============================================
- Hits           24451    24449       -2     
- Misses         12771    12772       +1     
- Partials        2728     2729       +1
Impacted Files Coverage Δ Complexity Δ
...xecutionsWithSameRootProcessInstanceIdMatcher.java 25% <0%> (-12.5%) 0% <0%> (ø)
...mpl/agenda/TakeOutgoingSequenceFlowsOperation.java 88.53% <0%> (-1.28%) 0% <0%> (ø)
.../entity/data/impl/MybatisExecutionDataManager.java 79.31% <0%> (+1.72%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf2065...b75d894. Read the comment docs.

@salaboy salaboy merged commit db9f1a3 into develop Nov 26, 2018
@salaboy salaboy deleted the igdianov-activiti-core-dependencies-tests branch November 26, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants