Implementation of ACTIVITY_SIGNALED event #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemedeiros
requested changes
Feb 20, 2019
There was a problem hiding this comment.
In addition to my comment you also need to add an integration test for it.
You can use ProcessDeployedEventIT as reference. You will need:
- start one or more instances of a process containing a intermediate catch signal
- send a signal
- check if your test listener received the related
SIGNAL_RECEIVEDevents
...rocess-runtime-impl/src/main/java/org/activiti/runtime/api/model/impl/ToSignalConverter.java
Outdated
Show resolved
Hide resolved
...untime-impl/src/main/java/org/activiti/runtime/api/event/impl/ToSignalReceivedConverter.java
Outdated
Show resolved
Hide resolved
...spring-boot-starter/src/test/java/org/activiti/spring/boot/process/ProcessRuntimeEvents.java
Outdated
Show resolved
Hide resolved
erdemedeiros
force-pushed
the
CTI777-2272-Missing-audit-event-apis-for-signals
branch
from
1aa4be8
to
09364a3
Compare
erdemedeiros
force-pushed
the
CTI777-2272-Missing-audit-event-apis-for-signals
branch
from
09364a3
to
2729e1a
Compare
erdemedeiros
approved these changes
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2511 +/- ##
=============================================
+ Coverage 61.09% 61.13% +0.03%
Complexity 1604 1604
=============================================
Files 1148 1151 +3
Lines 40589 40623 +34
Branches 5914 5915 +1
=============================================
+ Hits 24797 24833 +36
+ Misses 13032 13030 -2
Partials 2760 2760
Continue to review full report at Codecov.
|
erdemedeiros
deleted the
CTI777-2272-Missing-audit-event-apis-for-signals
branch
erdemedeiros
pushed a commit
to AlfrescoArchive/activiti-cloud-runtime-bundle-service
that referenced
this pull request
Apr 2, 2019
salaboy
pushed a commit
to AlfrescoArchive/activiti-cloud-runtime-bundle-service
that referenced
this pull request
Apr 16, 2019
* Add error-handling dependency to starters * Create exception handler specific to runtime bundle * Clean exception handlers scattered in controllers * Implementation of signalReceived event (#247) Related to Activiti/Activiti#2272 Depends on AlfrescoArchive/activiti-api#84 AlfrescoArchive/activiti-cloud-api#65 Activiti/Activiti#2511 * Fix audit producer test (#284) - Take in account new events thrown for signal received event that was not thrown before - Move test to SignalAuditProducerIT Related to Activiti/Activiti#2272 * Move CloudActivityBehaviorFactory to runtime bundle (#281) * Move CloudActivityBehaviorFactory to runtime bundle Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663 * Move CloudActivityBehaviorFactory to runtime bundle Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.11 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.12 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.13 * Change HttpStatus for int in RestControllerAdvice * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.14 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.24 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.25 * fix(version): update org.activiti.cloud.build:activiti-cloud-parent to 7.1.7 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.26 * Refactor ActivitiErrorMessage class * Refactor with MediaType constants * Refactor error handlers module * Add swagger generator test (#287) * Add swagger generator test * Produce swagger file as a Maven artifact - add plugin configuration to produce swagger file as a Maven artifact - produce both Alfresco and Hal format * Add yaml convertion from json * Add TODO to swagger yaml generation * Add generated yaml as an artifact * Add Gson prettifying features * Move Swagger generation inside a special type of test - Add a new configuration for failsafe plugin to hanle *ITSupport.java which will generate the swagger file - Create a profile generate-swagger enabled by default (can be skipped with `-DskipSwaggerGen` option) * Add comments * Add yaml generation back * Format swagger-hal.json at creation * Change scope for gson dependency to test * Add test scope to jackson-dataformat-yaml * A test to check that processDefinitionVersion set on TaskStarted event (#285) * A test to check that processDefinitionVersion set on TaskStarted event * Test modified to check only event's processDefinitionVersion * Remove icon from connecto definitions (#243) * Add common handlers module to rest-impl * Remove handler from ConnectorDefinitionControllerImpl * Clear exception handler * Change return type for exception handler * Optimize imports * Clear exception handler from ProcessInstanceControllerImpl * Fix test response type * Optimize imports * Change return type of error handler * Process instance description field removal (#262) * Process instance description field removal * Process instance description field removal * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.15 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.27 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.28 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.29 * Update pom.xml * Update pom * Add swagger artifacts to BOM (#292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2272
Depends on AlfrescoArchive/activiti-api#84