Implementation of ACTIVITY_SIGNALED event

[CTI777]

Related to Activiti/Activiti#2272
Depends on
AlfrescoArchive/activiti-api#84
AlfrescoArchive/activiti-cloud-api#65
Activiti/Activiti#2511

[erdemedeiros]

Can you add another assert to check that processDefinitionId and processInstanceId are set properly?

[CTI777]

@salaboy @erdemedeiros @igdianov
It seems that we have a problem with MessageProducerCommandContextCloseListener.
In the test when two processes are listening for one signal a processInstanceId in the events related to second process is overwritten with processInstanceId from the first process..
This bug should be fixed, maybe inside this PR? Details should be considered (discussed) additionally, because the header for the messages' bunch should be modified... And this may lead to failing of some other tests...

[salaboy]

@CTI777 hmm that doesn't sounds like the right behaviour.. we will need to investigate.. Please sync with @erdemedeiros about this.

[igdianov]

@salaboy the close listener injects the execution attributes into events before sending it to the stream under the assumption that there is always single process instance emitting events inside each transaction. This is apparently not the case, so it should be the responsibility of the event aggregator to resolve and apply correct values to each event when it is added to the list. Once the event is added to the list, it would be good practice to make it immutable. However, this is currently not possible because the setters are public. We could possibly wrap it into delegate to seal the event once we add it to the list.

I will help @CTI777 to fix this issue.

[erdemedeiros]

@igdianov on the same subject: I noticed that currently ProcessDeployedEvents are not setting headers at all (as they are not using closeListener). I created a specific MessageBuilderChainFactory to set only routing key and runtime bundle info headers in this PR . However it's not implementing the interface MessageBuilderChainFactory as I wasn't sure which information I could use add more information there (if there is any). This new MessageBuilderChainFactory is invoked in the CloudProcessDeployedProducer.

[igdianov]

@igdianov on the same subject: I noticed that currently ProcessDeployedEvents are not setting headers at all (as they are not using closeListener). I created a specific MessageBuilderChainFactory to set only routing key and runtime bundle info headers in this PR . However it's not implementing the interface MessageBuilderChainFactory as I wasn't sure which information I could use add more information there (if there is any). This new MessageBuilderChainFactory is invoked in the CloudProcessDeployedProducer.

@erdemedeiros I will take a look at it.

[igdianov]

@CTI777 @erdemedeiros This PR needs to be rebased on top of develop branch. We also need to add some tests to make sure that execution context is injected in signal audit events.

[codecov]

Codecov Report

Merging #247 into develop will decrease coverage by 0.35%.
The diff coverage is 35.71%.

@@              Coverage Diff              @@
##             develop     #247      +/-   ##
=============================================
- Coverage      73.17%   72.81%   -0.36%     
  Complexity         5        5              
=============================================
  Files            114      115       +1     
  Lines           1476     1490      +14     
  Branches          47       48       +1     
=============================================
+ Hits            1080     1085       +5     
- Misses           357      365       +8     
- Partials          39       40       +1

Impacted Files	Coverage Δ	Complexity Δ
...vents/listeners/ProcessEngineEventsAggregator.java	46.51% <0%> (-2.27%)	0 <0> (ø)
...converter/ToCloudProcessRuntimeEventConverter.java	15.38% <0%> (-1.64%)	0 <0> (ø)
...ts/configuration/CloudEventsAutoConfiguration.java	100% <100%> (ø)	0 <0> (ø)	⬇️
.../events/listeners/CloudSignalReceivedProducer.java	66.66% <66.66%> (ø)	0 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2896b91...f955582. Read the comment docs.

[igdianov]

@erdemedeiros I have fixed missing execution context attributes for CloudBPMNSignalEvent. See test.

There is a small nuisance with start event catch signal. The event is dispatched outside of transaction, so it's entity does not have associated process instance id to retrieve the details of current execution context.