This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Move CloudActivityBehaviorFactory to runtime bundle #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on Activiti/Activiti#2668 |
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
=============================================
+ Coverage 73.28% 73.48% +0.19%
Complexity 5 5
=============================================
Files 115 118 +3
Lines 1490 1501 +11
Branches 48 48
=============================================
+ Hits 1092 1103 +11
Misses 358 358
Partials 40 40
Continue to review full report at Codecov.
|
Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663
Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663
erdemedeiros
force-pushed
the
elias-2663-fix-core-throw-signal
branch
from
9ca35a1
to
b42e9d9
Compare
salaboy
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Add error-handling dependency to starters * Create exception handler specific to runtime bundle * Clean exception handlers scattered in controllers * Implementation of signalReceived event (#247) Related to Activiti/Activiti#2272 Depends on AlfrescoArchive/activiti-api#84 AlfrescoArchive/activiti-cloud-api#65 Activiti/Activiti#2511 * Fix audit producer test (#284) - Take in account new events thrown for signal received event that was not thrown before - Move test to SignalAuditProducerIT Related to Activiti/Activiti#2272 * Move CloudActivityBehaviorFactory to runtime bundle (#281) * Move CloudActivityBehaviorFactory to runtime bundle Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663 * Move CloudActivityBehaviorFactory to runtime bundle Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used. Related to Activiti/Activiti#2663 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.11 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.12 * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.13 * Change HttpStatus for int in RestControllerAdvice * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.14 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.24 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.25 * fix(version): update org.activiti.cloud.build:activiti-cloud-parent to 7.1.7 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.26 * Refactor ActivitiErrorMessage class * Refactor with MediaType constants * Refactor error handlers module * Add swagger generator test (#287) * Add swagger generator test * Produce swagger file as a Maven artifact - add plugin configuration to produce swagger file as a Maven artifact - produce both Alfresco and Hal format * Add yaml convertion from json * Add TODO to swagger yaml generation * Add generated yaml as an artifact * Add Gson prettifying features * Move Swagger generation inside a special type of test - Add a new configuration for failsafe plugin to hanle *ITSupport.java which will generate the swagger file - Create a profile generate-swagger enabled by default (can be skipped with `-DskipSwaggerGen` option) * Add comments * Add yaml generation back * Format swagger-hal.json at creation * Change scope for gson dependency to test * Add test scope to jackson-dataformat-yaml * A test to check that processDefinitionVersion set on TaskStarted event (#285) * A test to check that processDefinitionVersion set on TaskStarted event * Test modified to check only event's processDefinitionVersion * Remove icon from connecto definitions (#243) * Add common handlers module to rest-impl * Remove handler from ConnectorDefinitionControllerImpl * Clear exception handler * Change return type for exception handler * Optimize imports * Clear exception handler from ProcessInstanceControllerImpl * Fix test response type * Optimize imports * Change return type of error handler * Process instance description field removal (#262) * Process instance description field removal * Process instance description field removal * fix(version): update org.activiti.dependencies:activiti-dependencies to 7.1.15 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.27 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.28 * fix(version): update org.activiti.cloud.common:activiti-cloud-service-common-dependencies to 7.1.29 * Update pom.xml * Update pom * Add swagger artifacts to BOM (#292)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially CloudActivityBehaviorFactory was declared in set in Activiti core, but this was breaking intermediate throw signals when non-cloud starter was used.
Ref: Activiti/Activiti#2663