-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phase 7] Sharrow -- 1 Zone #579
Conversation
it fails later tests
because windows
…black # Conflicts: # activitysim/core/config.py # activitysim/examples/example_manifest.yaml # activitysim/examples/prototype_arc/configs/settings_mp.yaml
for base activitysim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A majority of the requested changes are around documentation. There's a lot of stuff added in here and I think we need to document well to mitigate any increase into the already steep learning curve of ActivitySim development or usage.
There are a number of comments and areas about the handling of maz level skims that I left under the assumption they will be addressed in the sharrow two and three zone work.
I have not gone through every file yet, especially ones in activitysim/workflows/. Will finish them and add more comments this week. |
Close in favor of #611 |
This PR supercedes #542, and is written with black enabled to simplify code review (relatively)