MacOs - Icon doesn't transition from dark to light

[rtpHarry]

For us to be able to understand the issue you're having you need to follow this template. Please make sure there isn't already an issue for the bug you've found, otherwise it'll just take more resources, which means less time for us to actually fix bugs. Thanks for reporting!

Describe the bug

I'm running the custom build from #334 and im excited that it's up and running now on my system.

I have the MacOS setting to automatically turn to dark mode in the evening, and back in the day.

Last night it was on dark mode, this morning I've come back and the tray icon hasn't updated, it's still white:

To Reproduce

Steps to reproduce the behavior:

1. Run ActivityWatch with MacOS on night mode
2. Wait until system goes back to day mode
3. Observe icon colour doesnt change

Expected behavior

Icon should turn black in day mode.

Environment

• ActivityWatch version:Version: v0.8.dev+c6433ea
• OS: macOS Catalina

[ErikBjare]

Ah yes, support for dark/light macOS theme was added in ActivityWatch/aw-qt#52

It looks to me like it wasn't done the proper way however. We added two icons and detected the theme at startup, while some suggest we should only have one and then use myQIcon.setIsMask(True) as described here, which supposedly lets Qt handle the transition itself.

Want to take a look at it @xylix?

[xylix]

Hm yes I'll take a look, probably later today or tomorrow.

I've personally avoided this bug since I only use dark mode on macOS nowadays :D. But thanks for the report rptharry, this shouldn't take too long to fix.

[rtpHarry]

FYI quitting and restarting loads it with the correct one