Most visited URLs

[ErikBjare]

I'd like to add a most visited URLs/hostnames to the Activity view.

What needs to be done:

• Filter events from web watcher through AFK events and then through active window events.
• If required bucket is missing, display message with which bucket types are needed for visualization to display.
  • This should probably be implemented for the other views as well instead of only showing a host in the Activity dropdown when all buckets needed exist.
• Add appname of both Firefox, Chrome and Chromium on both Windows, Mac and Linux so it works properly cross-platform

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[johan-bjareholt]

This is working as expected in firefox on linux on transform-next. Once we get the appname of chrome and firefox on macOS and Windows and whitelist those in the filtering in the query this issue should be done.

[ErikBjare]

@johan-bjareholt Nice, what happens if the user doesn't use the browser watcher? Will some useful message be displayed?

[johan-bjareholt]

It gives you a dropdown to select browser bucket from, and if there is none available it should show "No browser bucket available" if I remember correctly but havn't tested. Will be easy to fix a more in-your-face notice though which we probably should fix later.

[ErikBjare]

@johan-bjareholt Alright, great!

[johan-bjareholt]

Fixed in the webui so it recognizes whether it's a chrome or firefox bucket and filters both appropriately when the window is focused on Linux. So the only thing needed now is the appnames of firefox+chrome on windows and macOS and then it should be working reliably.

[ErikBjare]

Woah, that's really nice!

…

On Dec 22, 2017 21:03, "Johan Bjäreholt" ***@***.***> wrote: Fixed in the webui so it recognizes whether it's a chrome or firefox bucket and filters both appropriately when the window is focused on Linux. So the only thing needed now is the appnames of firefox+chrome on windows and macOS and then it should be working reliably. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABVxunFywssF8bTMdQNkhY_KnGCmO8Jdks5tC8vJgaJpZM4PBVUc> .

[johan-bjareholt]

Should hopefull work on all platforms now

ActivityWatch/aw-webui@1bc779f

[ErikBjare]

Doesn't seem to work for @exoji2e on macOS. Didn't have time to investigate further but he was running the latest commits.

Will check with him again soon.

[exoji2e]

It does work, the problem was that make build automatically checked out an old version of aw-webui.

When I run make build it echoes

if [ -d "aw-core/.git" ]; then \
		echo "Submodules seem to already be initialized, continuing..."; \
	else \
		git submodule update --init --recursive; \
	fi

And starts running git submodule update --init --recursive even though aw-code/.git exists, maybe this only occurs on macOS?

Oh wait, so .git is just a file:

~/r/a/aw-core> cat .git
gitdir: ../.git/modules/aw-core

A proposal would be to have two targets, one that does the recursive update and one that does not?

[ErikBjare]

Oh, didn't know the .git folder could be created as a symlink.

Could be easily fixed by changing that line into if [ -e "aw-core/.git" ];, will do now.

[ErikBjare]

@exoji2e Fixed, please try it now :)

[exoji2e]

Great, it works for me :)

[ErikBjare]

Alright! Then I think we can close this as soon as we fix proper error/warn/info messages in the cases of:

• Missing activity about an active browser window
• No data in web watcher bucket

[johan-bjareholt]

No data in web watcher bucket

Is this not already available? If you choose a day with a browser bucket without any data that specific day it will show "No Data"

Missing activity about an active browser window

Do you mean detect like "Hey I see that you are using Chrome, wanna install the AW extension?" or "I see that you had Chrome focused during this timeperiod but there is no activity in the browser bucket, something must've gone wrong"?

[ErikBjare]

@johan-bjareholt I'm not quite sure which of those I meant, but regardless it seems like a minor issue so lets just close this for now.

Awesome work overall 🎉

[johan-bjareholt]

Firefox-esr should be added on Linux aswell