Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a 404 error when loading the dashboard #144

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix a 404 error when loading the dashboard #144

merged 2 commits into from
Aug 2, 2023

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Jul 27, 2023

This PR fixes the following issues:


I added the missing parameters to the AWFlask class initialisation in the _start() method.
I also added the venv folder to the .gitignore file.


It definitely didn't take about 2 hours to figure out what's wrong :D

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7527c8d) 55.64% compared to head (9cabc8e) 55.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   55.64%   55.64%           
=======================================
  Files          11       11           
  Lines         629      629           
=======================================
  Hits          350      350           
  Misses        279      279           
Files Changed Coverage Δ
aw_server/server.py 77.27% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wakamex
Copy link

wakamex commented Jul 29, 2023

this works for me.

@ErikBjare
Copy link
Member

Very nice, thank you so much for finding this! ❤️

@ErikBjare ErikBjare merged commit 8b2cc22 into ActivityWatch:master Aug 2, 2023
8 checks passed
@BelKed BelKed deleted the fix-404 branch August 2, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 Error 404 error when loading the dashboard
3 participants