Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wip): started working on category sets #369

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Sep 9, 2022

TODO

  • Make Activity view actually pick up the current category set
  • Check that import & export works as expected (move buttons a bit)
    • What should happen on duplicate import? Add suffix to ID of imported set?

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 25.58% // Head: 25.23% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (03f310f) compared to base (1980a40).
Patch coverage: 34.17% of modified lines in pull request are covered.

❗ Current head 03f310f differs from pull request most recent head 8b9d085. Consider uploading reports for the commit 8b9d085 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   25.58%   25.23%   -0.36%     
==========================================
  Files          26       26              
  Lines        1442     1474      +32     
  Branches      226      233       +7     
==========================================
+ Hits          369      372       +3     
- Misses       1020     1048      +28     
- Partials       53       54       +1     
Impacted Files Coverage Δ
src/util/color.ts 31.66% <0.00%> (ø)
src/util/classes.ts 69.42% <16.12%> (-13.41%) ⬇️
src/stores/categories.ts 58.09% <46.80%> (-5.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 9, 2022

This pull request introduces 1 alert when merging 03f310f into 1980a40 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 24, 2022

This pull request introduces 1 alert when merging 8b9d085 into 1980a40 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant