display offersession promise failure instead of showing console errors (

mrdoob#27492) * display offersession promise failure instead of showing console errors * change log() to warn() for offersession handler
AdaRoseCannon · Jan 15, 2024 · 06fd21e · 06fd21e
1 parent b2f9887
commit 06fd21e
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 6 deletions.
diff --git a/examples/jsm/webxr/ARButton.js b/examples/jsm/webxr/ARButton.js
@@ -107,7 +107,12 @@ class ARButton {
 					if ( navigator.xr.offerSession !== undefined ) {
 
 						navigator.xr.offerSession( 'immersive-ar', sessionInit )
-							.then( onSessionStarted );
+							.then( onSessionStarted )
+							.catch( ( err ) => {
+
+								console.warn( err );
+
+							} );
 
 					}
 
@@ -118,7 +123,12 @@ class ARButton {
 			if ( navigator.xr.offerSession !== undefined ) {
 
 				navigator.xr.offerSession( 'immersive-ar', sessionInit )
-					.then( onSessionStarted );
+					.then( onSessionStarted )
+					.catch( ( err ) => {
+
+						console.warn( err );
+
+					} );
 
 			}
 

diff --git a/examples/jsm/webxr/VRButton.js b/examples/jsm/webxr/VRButton.js
@@ -73,7 +73,12 @@ class VRButton {
 					if ( navigator.xr.offerSession !== undefined ) {
 
 						navigator.xr.offerSession( 'immersive-vr', sessionInit )
-							.then( onSessionStarted );
+							.then( onSessionStarted )
+							.catch( ( err ) => {
+
+								console.warn( err );
+
+							} );
 
 					}
 
@@ -84,7 +89,12 @@ class VRButton {
 			if ( navigator.xr.offerSession !== undefined ) {
 
 				navigator.xr.offerSession( 'immersive-vr', sessionInit )
-					.then( onSessionStarted );
+					.then( onSessionStarted )
+					.catch( ( err ) => {
+
+						console.warn( err );
+
+					} );
 
 			}
 

diff --git a/examples/jsm/webxr/XRButton.js b/examples/jsm/webxr/XRButton.js
@@ -77,7 +77,12 @@ class XRButton {
 					if ( navigator.xr.offerSession !== undefined ) {
 
 						navigator.xr.offerSession( mode, sessionOptions )
-							.then( onSessionStarted );
+							.then( onSessionStarted )
+							.catch( ( err ) => {
+
+								console.warn( err );
+
+							} );
 
 					}
 
@@ -88,7 +93,12 @@ class XRButton {
 			if ( navigator.xr.offerSession !== undefined ) {
 
 				navigator.xr.offerSession( mode, sessionOptions )
-					.then( onSessionStarted );
+					.then( onSessionStarted )
+					.catch( ( err ) => {
+
+						console.warn( err );
+
+					} );
 
 			}