display offersession promise failure instead of showing console errors #27492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabanier
force-pushed
the
offersession_fail
branch
from
1954daf
to
bfa39d3
Compare
Mugen87
approved these changes
Jan 4, 2024
Mugen87
reviewed
Jan 4, 2024
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
mrdoob#27492) * display offersession promise failure instead of showing console errors * change log() to warn() for offersession handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A developer complained that when they put multiple buttons on the page, they get errors in the js console.
These errors are harmless failed promises from
offerSessionbut they claim that people don't like to see errors in the console.This PR will catch the failed promises and show them as console warnings
This contribution is funded by Meta