Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear gesture recognizers on tear down #12

Open
domneedham opened this issue Apr 30, 2024 · 3 comments
Open

Clear gesture recognizers on tear down #12

domneedham opened this issue Apr 30, 2024 · 3 comments

Comments

@domneedham
Copy link

First of all, thanks for this project. It helps identify issues massively!

I noticed that whilst the page is cleared down much better, our view models were not getting cleaned out. Doing some digging, it seems that tap gesture recognizers keep their reference and aren't cleared.

Adding the following snippet helped clear these instances that were not previously.

if (vte is IGestureRecognizers gr)
{
    gr.GestureRecognizers.Clear();
}

I have not raised a PR as you may not choose use to it and/or have alternate ideas based on this.

Happy to discuss more.

@AdamEssenmacher
Copy link
Owner

Agreed. PR or I'll try to get to it when I can.

@domneedham
Copy link
Author

Agreed. PR or I'll try to get to it when I can.

Did you want me to raise a PR for all the issues I've raised as one, or separately?

@AdamEssenmacher
Copy link
Owner

Either is fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants