The "DromedaryCase" bug: myaggregateId GOOD, myAggregateId BAD

[robertreppel]

CamelCase doesn't work; it assumes that the 'I' in "Id" at the end of aggregate/stream id parameters and properties is the only uppercase char. Fails without les validate error and results in broken les-node API code.

For example: inventoryitemId vs. inventoryItemId

This works:

Receive Product-> // productId, description
InventoryItem Stocked // inventoryitemId, sku, description, purchasePrice, quantityAvailable
InventoryitemLookup* // inventoryitemId, productId, description

This passes les validate but results in a broken les-node -b API:

Receive Product-> // productId, description
InventoryItem Stocked // inventoryItemId, sku, description, purchasePrice, quantityAvailable
InventoryitemLookup* // inventoryItemId, productId, description

[mohkami]

I'm not quite sure what should be the expected behaviour here.
On this line, we are explicitly making sure that we are changing letters to lower case:
https://github.com/Adaptech/les/blob/master/pkg/convert/emdToEml.go#L300

//Ensure consistent casing for stream Ids: e.g. TimesheetHoursId is represented as "timesheethoursId".

If we want to keep the property's name in the case it is, we just need to change the next line (301) to the following:
event.Event.Properties[index].Name = parameter.Name[:len(parameter.Name)-2] + "Id"

[robertreppel]

Yes, but if I recall correctly there are side effects caused by this elsewhere in the code. I'll take a look and try it out.