-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During fingerprinting, AVHashes returns empty when specifying secondsToProcess and startAtSecond while creating both audio and video fingerprints #207
Comments
Can you please attach a file and provide the exact parameter values for both |
Here is the sample file (downloaded format #22 with yt-dlp) yt-dlp -f 22 https://www.youtube.com/watch?v=4sebEgloQEM secondsToProcess = 10 While playing around with it, it does seem that the particular values above are involved in the issue. There were some, like secondsToProcess = 10, and startsAtSecond = 1 which did appear to work. In my use case, the secondsToProcess and startsAtSecond values are always doubles (many decimals) and are retrieved from previous query result matches. The above is just a contrived example with a sample file. |
It is fixed in v8.24.0, you will need to upgrade SoundFingerprinting.Emy to fix version. Link to NuGet package: https://www.nuget.org/packages/SoundFingerprinting.Emy/8.24.0 |
Describe the bug
When fingerprinting (haven't tested query yet) both audio and video simultaneously, if you supply secondsToProcess and startsAtSecond paramaters the AVHashes returned is always empty (isEmpty=true). Fingerprints are returned as expected if only MediaType.Audio or MediaType.Video are specified, but both (MediaType.Audio | MediaType.Video) does not. Based on the time it takes, it seems likely it is doing neither video or audio hashing of any kind, and just returning the empty AVHash.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Returned fingerprint hashes for both video and audio from the timerange specified by secondsToProcess and startsAtSecond, instead of an empty AVHashes containing no fingerprints.
Targeting: .Net v4.6.1
Using nuGet Packages: SoundFingerprinting.8.23.0, SoundFingerprinting.Emy.8.23.23, FFmpeg.AutoGen.Abstractions.6.0.0.2
Using git build of ffmpeg pre-compiled from here : https://github.com/BtbN/FFmpeg-Builds/releases/download/autobuild-2023-06-21-15-24/ffmpeg-N-111233-g83b3ff741b-win64-gpl-shared.zip
The text was updated successfully, but these errors were encountered: