Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: TLS handshake error #1167

Closed
ammnt opened this issue Nov 8, 2019 · 3 comments
Closed

http: TLS handshake error #1167

ammnt opened this issue Nov 8, 2019 · 3 comments
Assignees
Milestone

Comments

@ammnt
Copy link

ammnt commented Nov 8, 2019

Hello,

VPS, Debian 9, AGH 0.99.2. I'm not sure it 's a bug. But when I use the web-interface, i at once see a errors in the log:

2019/11/08 20:58:50 http: TLS handshake error from IP:53525: EOF
2019/11/08 21:37:59 http: TLS handshake error from IP:55822: EOF
2019/11/08 21:45:27 http: TLS handshake error from IP:56389: EOF

I use a certificate from Lets Encrypt for DoH, DoT, and HTTPS. DoT/DoH handshakes works without any errors. Tests on ssllabs.com and sslshopper.com successful. I can send the configuration file, domain and full logs to devteam@adguard.com.

Something similar is described here:
https://stackoverflow.com/questions/34823724/golang-tls-handshake-error
https://stackoverflow.com/questions/39547459/golang-http2-and-tls-handshake-errors

Thank you.

@ameshkov
Copy link
Member

This means that the client closed connections unexpectedly, this is not really a problem.

I think we should simply log this with DEBUG level, not ERROR.

@szolin
Copy link
Contributor

szolin commented Nov 13, 2019

These don't seem like our log messages. What application writes these logs?

@ameshkov
Copy link
Member

@szolin it's ours of course. We should've configured ErrorLog *log.Logger for the http.Server instance.

@szolin szolin self-assigned this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants