Use ECS (EDNS Client subnet) to identify Clients, instead of IP address

[gspannu]

The edge build now displays the ECS data in the response section in Query Log.
Would there be a feature added where this (ECS subnet data) IP address is used to identify the client, instead of (or in addition to) the Public IP address.

See attached screenshot.

Would it be possible to have a feature that uses the ECS data (4.5.6.0) to identify the client instead of the connecting IP (212.139.50.250) ?
A user choice/ option to display/ store all logs and statistics to be based on either client IP or connecting IP?

---

@gtxaspec, we've got a couple of ECS-related issues already (e.g. #1727, #2514). Do you mean duplicating this info to the "Client details" of the same query log entry?

So far, it seems the issue may be closed for now. Please consider opening a new one if it isn't yet.

Originally posted by @EugeneOne1 in #3978 (comment)

[gtxaspec]

@gspannu

Yes, this what I was referring to, lets have the ability to filter and sort clients in the query logs by the ECS data, if possible. I didn't see another issue open for this specific type of request.

[gspannu]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Has this now been implemented in some release or any plans for release? ECS-related issues (1727, 2514).

[ainar-g]

This could be done, but I'm not sure if this should be enabled by default, since technically anyone can put anything there, which may cause all kinds of issues.

[gspannu]

This could be done, but I'm not sure if this should be enabled by default, since technically anyone can put anything there, which may cause all kinds of issues.

Just looking at an

• option to sort/ search query log by subnet data.
• statistics based on subnet data

I fully agree that it shouldn't be enabled by default.

[gtxaspec]

@ainar-g any update on this? I believe feasibly, if the AdGuard team would add a switch, something like display_ecs_as_client: true/false (false by default) would be a great benefit, since ecs data is interpreted by AGH now.

This would gain AGH feature parity with other solutions like pi-hole.

[jumpsmm7]

@ainar-g
I wonder where we are at with this ? It seems all these feature requests for EDNS (ECS) are broken into small requests. It is hard to keep track of what state AdGuardHome is at with developing EDNS (ECS) support.

For example, #1727 (comment)

[ainar-g]

@jumpsmm7, thanks for drawing my attention to it. You're correct that this can be merged into #1727.