Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked services API: List available services #4535

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

RoboMagus
Copy link
Contributor

Related to FR #4520

This PR adds GET /blocked_services/services that will return a full list of the service names that can be blocked using the blocked_services API.

It seemed quite easy to implement, though I must declare that I am NOT proficient in Go...

@ainar-g
Copy link
Contributor

ainar-g commented Apr 29, 2022

Hello and thank you for that contribution! We've actually planned to postpone that until a proper API refactoring that we planned to do later in the v0.108 cycle, but since you've already provided an implementation, we'll try to review your contribution next week. Be aware, though, that when the refactoring comes, it is likely that this API will be rewritten.

@ainar-g ainar-g self-requested a review April 29, 2022 17:09
@ainar-g ainar-g self-assigned this Apr 29, 2022
@ainar-g ainar-g added this to the v0.108.0 milestone Apr 29, 2022
@RoboMagus
Copy link
Contributor Author

Thanks for taking a look into this. It's good to hear that these api changes are already on the roadmap. In that case it might be best to first iron out what the api should look like.

Is there an estimated time frame for when v0.108 is to be released? Cause then I'll postpone work on my integration that interacts with the api until it arrives.

@ainar-g
Copy link
Contributor

ainar-g commented Jun 14, 2022

@RoboMagus, apologies for the late response. There are no exact deadlines currently, unfortunately. We'll see if we'll be able to fit this into one of the patch releases for the v0.107 branch, but I cannot give any promises on that.

@frenck
Copy link
Contributor

frenck commented Jul 16, 2022

This feature is very much wished for, for the Home Assistant project as well. It would allow us to create switches in Home Assistant to automate on. Right now, we can't, as we can't get a list of services.

@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.12 Aug 25, 2022
adguard pushed a commit that referenced this pull request Aug 25, 2022
Updates #4535.

* commit '986124948a21b5dfebb0bd6a9f948911b0a4b938':
  all: imp client, add api chlog
  filtering: imp code
  Add '/blocked_services/services' API
@adguard adguard merged commit 57c0b12 into AdguardTeam:master Aug 25, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Aug 25, 2022

@RoboMagus, @frenck, we have decided to merge this into v0.107.12. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants