-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer IPv4/6. However, it does not affect the resolution of pure IPv6/4 domain names. #5919
Comments
I want to use prefer_ipv6. Currently AdGuardHome is only able to brute force disable ipv6, which is not what I want. |
Some backward websites only support IPv4. Therefore, IPv4 cannot be simply turned off. |
Duplicate of #4482. |
*$dnstype=A,dnsrewrite=NOERROR ||internal.my-campus.edu^$dnstype=A,dnsrewrite=NOERROR Some applications lack settings and they ignore the operating system's configuration. |
@57382, I do not understand your request, sorry. The only preference we currently have is |
I want to add the following functionality: vice versa. If I want to force only A records to be returned, the AAAA records are removed, but disabled for domains that only have AAAA records. Another open source resolver, MOSDNS, has the above functions. MOSDNS uses the parameters prefer_ipv6 and prefer_ipv4 to achieve the above behavior. You can refer to this part of code of MOSDNS, implemented for AdGuardHome. |
I see. That would require us to essentially either query upstreams for both |
As a client application it knows nothing. Sometimes one needs to override the behavior of the client application. It is beneficial to implement this functionality. It doesn't do any harm. Black and white list mode is also available for this purpose. This increases compatibility from 99% to 100%. Works on all sites. Accelerate the network silently. |
So what about CNAMEs? What if the application require and only requests A but the domain also has AAAA results? I think it should be the behavior of the system and application itself, and AdGuardHome should do its own thing, just as I said #4482 (comment) here. By the way, as @ainar-g said above:
That's exactly what I meant. |
The client application should serve me from start to finish. The DNS client app is usually alive, but if he's killing himself, I'll stop it! And you will silently watch him die. This is what makes us different. I can't watch stupid things happen. You seem to be able to. There is nothing special about CNAME. Use blacklists and whitelists to rule out any problematic domains. CNAME is in it. So CNAME won't break anything. AdGuardHome has done a lot. Is DNSCrypt V2 support something an ad filter should do? no way. What about speed testing against resolved IP? AdGuardHome has already done it. It seems like this IP speed test feature should be removed, prompting AdGuardHome to grow into a pure ad filter. you're right. Being able to speed boost the network makes AdGuardHome more competitive among its peers. |
Please keep discussions about the future to the Discussions section. We'd like to keep the Issues section on-topic. |
This is a very good suggestion. Just like mosdns, dual-stack domain names can only return IPV4/IPV6, but it does not affect pure IPV4/IPV6 domain names. |
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
The problem
prefer_ipv4 and prefer_ipv6 are two operations. In the following, for the convenience of expression, only prefer_ipv4 is taken as an example. prefer_ipv6 is the same.
prefer_ipv4 Allows downstream clients to use IPv4 first when they support dual-stack. When prefer_ipv4 processes an AAAA request, it will automatically send an A request to test whether the domain name is dual-stack, and the newly generated A request will continue to execute subsequent rules together with the original AAAA request. If both A and AAAA requests get IP (the domain name is dual-stack) at last, the original AAAA request will be blocked.
Proposed solution
@ainar-g
reference https://irine-sistiana.gitbook.io/mosdns-wiki/mosdns-v5/ru-he-pei-zhi-mosdns/sequence-cha-jian#prefer_ipv4-6
Alternatives considered and additional information
No response
The text was updated successfully, but these errors were encountered: