Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGH fails to start when the query log is corrupted #753

Closed
Onepamopa opened this issue May 8, 2019 · 9 comments
Closed

AGH fails to start when the query log is corrupted #753

Onepamopa opened this issue May 8, 2019 · 9 comments
Assignees
Milestone

Comments

@Onepamopa
Copy link

Onepamopa commented May 8, 2019

Failed to decode: invalid character '\x00' looking for beginning of value

Unable to start AdGuardHome at all, this log message spams the syslog.

The problem is related to unexpected power down of the linux machine. The query log file was causing the problem when AdGuardHome was initializing.

After removing the contents of query log, it runs normally.

@Eyeborgs
Copy link

I had it on Windows 10 after an emergency restart.

@Onepamopa
Copy link
Author

They should do some sanity-check on the log before loading, else it spams a lot of these...

@ameshkov ameshkov changed the title Failed to decode: invalid character '\x00' looking for beginning of value AGH fails to start when the query log is corrupted May 11, 2019
@ameshkov
Copy link
Member

Thank you for reporting this! This needs to be addressed indeed.

@Onepamopa
Copy link
Author

Onepamopa commented May 12, 2019

@ameshkov Not only that it fails to start, it can fill a 60GB partition with "failed to decode" in 10-20 minutes.... On the server currently deployed it grew the syslog to 26 GB in ~15 minutes.

@szolin
Copy link
Contributor

szolin commented May 13, 2019

In an attempt to skip corrupted log entries when reading from file we put the program into an endless loop. We should stop reading from a corrupted log file, delete it, and then start operating as normal.

@Onepamopa
Copy link
Author

@szolin or just skip the corrupted lines and proceed.

@ilya-fedin
Copy link

Are there any progress on this issue? This bug is very painful when AGH acts as a DHCP server. It would be very good if AGH renamed (but did not delete) the existing log and reported damage in the web interface.

@ameshkov ameshkov added this to the v0.100 milestone Oct 18, 2019
@ameshkov
Copy link
Member

@ilya-fedin assigned this but to v0.100, thanks for reminding us!

@szolin
Copy link
Contributor

szolin commented Oct 18, 2019

In the upcoming v0.99 this issue won't affect startup anymore.
However, we still need to skip corrupted lines.

@ameshkov ameshkov modified the milestones: v0.100, v0.99.2 Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants