New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while parsing wide filtering rule #556

Closed
ameshkov opened this Issue Feb 13, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Feb 13, 2017

Source:
AdguardTeam/AdguardForAndroid#1009

Review:
adguard-java-code/review/AJC-CR-158

@ameshkov ameshkov added this to the 2.6 milestone Feb 13, 2017

Mizzick added a commit that referenced this issue Feb 21, 2017

@Mizzick Mizzick closed this Feb 21, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Feb 27, 2017

Member

We still have a problem. @Mizzick Please, check the following rule |$domain=test.com,script

Member

atropnikov commented Feb 27, 2017

We still have a problem. @Mizzick Please, check the following rule |$domain=test.com,script

@atropnikov atropnikov reopened this Feb 27, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Feb 27, 2017

Member

@Mizzick add a test case for it.

Member

ameshkov commented Feb 27, 2017

@Mizzick add a test case for it.

Mizzick added a commit that referenced this issue Feb 27, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Feb 27, 2017

Contributor

It's ok, isn't it?

Contributor

Mizzick commented Feb 27, 2017

It's ok, isn't it?

@Mizzick Mizzick closed this Feb 27, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Feb 27, 2017

Member

Rule |$domain=test.com,script regexp isn't correct.

Member

atropnikov commented Feb 27, 2017

Rule |$domain=test.com,script regexp isn't correct.

@atropnikov atropnikov reopened this Feb 27, 2017

@Mizzick Mizzick closed this in c89ac8d Feb 27, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Feb 27, 2017

Member
var rule = new adguard.rules.UrlFilterRule('||$domain=test.com,script');
assert.ok(rule.isFiltered("http://example.com", true, adguard.RequestTypes.SCRIPT));

This test should not fail, but it does.

Member

atropnikov commented Feb 27, 2017

var rule = new adguard.rules.UrlFilterRule('||$domain=test.com,script');
assert.ok(rule.isFiltered("http://example.com", true, adguard.RequestTypes.SCRIPT));

This test should not fail, but it does.

@atropnikov atropnikov reopened this Feb 27, 2017

Mizzick added a commit that referenced this issue Feb 27, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Feb 27, 2017

Contributor

Ok, check this pull request

Contributor

Mizzick commented Feb 27, 2017

Ok, check this pull request

@Mizzick Mizzick closed this Feb 27, 2017

Mizzick added a commit that referenced this issue Mar 5, 2017

Mizzick added a commit that referenced this issue Mar 5, 2017

Mizzick added a commit that referenced this issue Mar 6, 2017

Mizzick added a commit that referenced this issue Mar 15, 2017

Mizzick added a commit that referenced this issue Mar 15, 2017

atropnikov added a commit that referenced this issue Mar 15, 2017

#556
Small fixes;

atropnikov added a commit that referenced this issue Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment