Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while parsing wide filtering rule #556

Closed
ameshkov opened this issue Feb 13, 2017 · 6 comments
Closed

Error while parsing wide filtering rule #556

ameshkov opened this issue Feb 13, 2017 · 6 comments
Assignees
@Mizzick
Milestone
2.6

Comments

@ameshkov
Copy link
Member

Source:
AdguardTeam/AdguardForAndroid#1009

Review:
adguard-java-code/review/AJC-CR-158
@ameshkov ameshkov added this to the 2.6 milestone Feb 13, 2017
Mizzick added a commit that referenced this issue Feb 21, 2017
@Mizzick
#556 bug fix
c7bedbe
@Mizzick Mizzick closed this as completed Feb 21, 2017
@atropnikov
Copy link
Member

We still have a problem. @Mizzick Please, check the following rule |$domain=test.com,script

@atropnikov atropnikov reopened this Feb 27, 2017
@ameshkov
Copy link
Member Author

@Mizzick add a test case for it.

Mizzick added a commit that referenced this issue Feb 27, 2017
@Mizzick
#556 test added
6073a02
@Mizzick
Copy link
Contributor

Mizzick commented Feb 27, 2017

It's ok, isn't it?

@Mizzick Mizzick closed this as completed Feb 27, 2017
@atropnikov
Copy link
Member

Rule |$domain=test.com,script regexp isn't correct.

@atropnikov atropnikov reopened this Feb 27, 2017
@atropnikov
Copy link
Member 

var rule = new adguard.rules.UrlFilterRule('||$domain=test.com,script');
assert.ok(rule.isFiltered("http://example.com", true, adguard.RequestTypes.SCRIPT));

This test should not fail, but it does.

@atropnikov atropnikov reopened this Feb 27, 2017
Mizzick added a commit that referenced this issue Feb 27, 2017
@Mizzick
#556 Any url rules regexp
1899994
@Mizzick Mizzick mentioned this issue Feb 27, 2017
Closed
@Mizzick
Copy link
Contributor

Mizzick commented Feb 27, 2017

Ok, check this pull request

@Mizzick Mizzick closed this as completed Feb 27, 2017
Mizzick added a commit that referenced this issue Mar 5, 2017
@Mizzick
Revert: #556
5720670
Mizzick added a commit that referenced this issue Mar 5, 2017
@Mizzick
Fix #556 regexp any symbol
b8bcd54
@Mizzick Mizzick mentioned this issue Mar 5, 2017
Merged
Mizzick added a commit that referenced this issue Mar 6, 2017
@Mizzick
Merge pull request #570 from AdguardTeam/feature/issues/556-2
d4bc518 
Fix #556 regexp any symbol
Mizzick added a commit that referenced this issue Mar 15, 2017
@Mizzick
Fix #556 regexp any symbol
00b1dd7
@Mizzick Mizzick mentioned this issue Mar 15, 2017
Merged
Mizzick added a commit that referenced this issue Mar 15, 2017
@Mizzick
Fix #556 regexp any symbol
f27b184
atropnikov added a commit that referenced this issue Mar 15, 2017
@atropnikov
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/556
e30ad60 
Small fixes;
atropnikov added a commit that referenced this issue Mar 15, 2017
@atropnikov
Merge pull request #593 from AdguardTeam/feature/issues/556-2
a96c1e9 
Fix #556 regexp any symbol
adguard pushed a commit that referenced this issue Dec 16, 2019
@maximtop
Merge pull request #556 in EXTENSIONS/browser-extension from feature/…
ae4c678 
…1549 to master

* commit '0f73758e0f002fefa3b0f60b8cd425211f4ae686':
  feature/1549 parse expires for custom filter
  feature/1549 add default update period
  feature/1549 fix eslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
None yet
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@atropnikov @ameshkov @Mizzick