Possible websockets blocking issue

[vozersky]

Test fails in Safari

[atropnikov]

@vozersky Which test did fail? I cannot reproduce it.

[vozersky]

@atropnikov the one I mentioned in the first post (2. Test blocking simple websocket connection)

[ameshkov]

What's exact Safari version?

It was fixed a long time ago:
#299

[vozersky]

@ameshkov Version 10.1 (12603.1.30.0.34)

[ameshkov]

We might need to fix the test code. @atropnikov please assist.

[atropnikov]

@ameshkov What do you mean? Check the version of Safari in tests, or something else?

[ameshkov]

First of all we should figure out why test fails. Could it be that WebSocket does not throw error or something like that?

[atropnikov]

I found a reason of the problem. Test filter contains ||echo.websocket.org/?blocked rule.
We replace || with var URL_FILTER_REGEXP_START_URL = "^https?://([^/]*\\.)?";
That's why WS connection isn't blocked.

[ameshkov]

@atropnikov we should've resolved it long ago, || should cover WebSocket as well. However, it'd be better to leave regexp pattern relatively simple.

[ameshkov]

I wonder, what will be the difference in performance?
^(http|ws)s?

[atropnikov]

Safari doesn't support |