New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible websockets blocking issue #586

Closed
vozersky opened this Issue Mar 10, 2017 · 11 comments

Comments

Projects
None yet
3 participants
@vozersky
Member

vozersky commented Mar 10, 2017

Test fails in Safari

@vozersky vozersky added the Question label Mar 10, 2017

@vozersky vozersky added this to the 2.6.0 Beta milestone Mar 10, 2017

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Mar 14, 2017

Member

@vozersky Which test did fail? I cannot reproduce it.

Member

atropnikov commented Mar 14, 2017

@vozersky Which test did fail? I cannot reproduce it.

@atropnikov atropnikov self-assigned this Mar 14, 2017

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Mar 30, 2017

Member

@atropnikov the one I mentioned in the first post (2. Test blocking simple websocket connection)

Member

vozersky commented Mar 30, 2017

@atropnikov the one I mentioned in the first post (2. Test blocking simple websocket connection)

@vozersky vozersky closed this Mar 30, 2017

@vozersky vozersky reopened this Mar 30, 2017

@atropnikov atropnikov modified the milestones: 2.6, 2.6.0 Beta Mar 30, 2017

@vozersky vozersky added the Safari label Apr 4, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 4, 2017

Member

What's exact Safari version?

It was fixed a long time ago:
#299

Member

ameshkov commented Apr 4, 2017

What's exact Safari version?

It was fixed a long time ago:
#299

@vozersky

This comment has been minimized.

Show comment
Hide comment
@vozersky

vozersky Apr 5, 2017

Member

@ameshkov Version 10.1 (12603.1.30.0.34)

Member

vozersky commented Apr 5, 2017

@ameshkov Version 10.1 (12603.1.30.0.34)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 5, 2017

Member

We might need to fix the test code. @atropnikov please assist.

Member

ameshkov commented Apr 5, 2017

We might need to fix the test code. @atropnikov please assist.

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Apr 6, 2017

Member

@ameshkov What do you mean? Check the version of Safari in tests, or something else?

Member

atropnikov commented Apr 6, 2017

@ameshkov What do you mean? Check the version of Safari in tests, or something else?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 6, 2017

Member

First of all we should figure out why test fails. Could it be that WebSocket does not throw error or something like that?

Member

ameshkov commented Apr 6, 2017

First of all we should figure out why test fails. Could it be that WebSocket does not throw error or something like that?

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Apr 6, 2017

Member

I found a reason of the problem. Test filter contains ||echo.websocket.org/?blocked rule.
We replace || with var URL_FILTER_REGEXP_START_URL = "^https?://([^/]*\\.)?";
That's why WS connection isn't blocked.

Member

atropnikov commented Apr 6, 2017

I found a reason of the problem. Test filter contains ||echo.websocket.org/?blocked rule.
We replace || with var URL_FILTER_REGEXP_START_URL = "^https?://([^/]*\\.)?";
That's why WS connection isn't blocked.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 6, 2017

Member

@atropnikov we should've resolved it long ago, || should cover WebSocket as well. However, it'd be better to leave regexp pattern relatively simple.

Member

ameshkov commented Apr 6, 2017

@atropnikov we should've resolved it long ago, || should cover WebSocket as well. However, it'd be better to leave regexp pattern relatively simple.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Apr 6, 2017

Member

I wonder, what will be the difference in performance?
^(http|ws)s?

Member

ameshkov commented Apr 6, 2017

I wonder, what will be the difference in performance?
^(http|ws)s?

@atropnikov

This comment has been minimized.

Show comment
Hide comment
@atropnikov

atropnikov Apr 6, 2017

Member

Safari doesn't support |

Member

atropnikov commented Apr 6, 2017

Safari doesn't support |

atropnikov added a commit that referenced this issue Apr 6, 2017

atropnikov added a commit that referenced this issue Apr 6, 2017

atropnikov added a commit that referenced this issue Apr 6, 2017

@atropnikov atropnikov closed this Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment