Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$websocket modifier works incorrectly in Safari #597

Closed
Alex-302 opened this issue Mar 20, 2017 · 8 comments
Closed

$websocket modifier works incorrectly in Safari #597

Alex-302 opened this issue Mar 20, 2017 · 8 comments
Assignees
@Mizzick
Labels
Bug Safari
Milestone
2.6

Comments

@Alex-302
Copy link
Member

The rule $websocket,domain=123movies.is blocks too much.
How to reproduce:
@atropnikov atropnikov added this to the 2.6 milestone Mar 22, 2017
@Mizzick
Copy link
Contributor

Mizzick commented Mar 22, 2017

@Alex-302 any other example?
Can't open 123movies.is.
On yandex.ru it seems to be ok.

@Alex-302
Copy link
Member Author

@Mizzick sure.

$websocket,domain=$websocket,domain=news.yandex.ru

image

Filters was disabled.

@Mizzick
Copy link
Contributor

Mizzick commented Mar 22, 2017

Well it blocks any "raw" resource-type now on Safari. We don't have any option to pick websocket requests.

@Mizzick Mizzick closed this as completed Mar 22, 2017
@Alex-302
Copy link
Member Author

Is not it better to ignore $websocket in Safari? Existing break the sites.

@Alex-302 Alex-302 reopened this Mar 22, 2017
@Alex-302
Copy link
Member Author

The problem is not in unblocked websockets.

@atropnikov atropnikov mentioned this issue Mar 23, 2017
Closed
@ameshkov
Copy link
Member

Guys, that's EASY.

We should convert $websocket rules to |ws*://

@ameshkov
Copy link
Member

Being more precise:

  1. If rule matches ANY URL
    AND
  2. If rule's content type EQUALS to websocket

THEN
|ws*://*

Mizzick added a commit that referenced this issue Mar 24, 2017
@Mizzick
#597 fix safari converter websockets
11037cb
Mizzick added a commit that referenced this issue Mar 24, 2017
@Mizzick
#597 fix safari converter websockets
68c89b9
@Mizzick
Copy link
Contributor

Mizzick commented Mar 24, 2017

Ok, fixed

@Mizzick Mizzick closed this as completed Mar 24, 2017
@Mizzick Mizzick mentioned this issue Mar 24, 2017
Merged
@Mizzick Mizzick removed the Wontfix label Apr 13, 2017
adguard pushed a commit that referenced this issue Mar 20, 2020
@slavaleleka
Merge pull request #597 in EXTENSIONS/browser-extension from feature/…
6ae505f 
…AG-1348 to master

* commit '0c39a2918893386f7c9d510cd30fe14099b3e7e6':
  update scriptlets to v1.1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Bug Safari
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
4 participants
@atropnikov @ameshkov @Alex-302 @Mizzick