New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$websocket modifier works incorrectly in Safari #597

Closed
Alex-302 opened this Issue Mar 20, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@Alex-302
Member

Alex-302 commented Mar 20, 2017

The rule $websocket,domain=123movies.is blocks too much.
How to reproduce:

@atropnikov atropnikov added this to the 2.6 milestone Mar 22, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 22, 2017

Contributor

@Alex-302 any other example?
Can't open 123movies.is.
On yandex.ru it seems to be ok.

Contributor

Mizzick commented Mar 22, 2017

@Alex-302 any other example?
Can't open 123movies.is.
On yandex.ru it seems to be ok.

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Mar 22, 2017

Member

@Mizzick sure.

$websocket,domain=$websocket,domain=news.yandex.ru

image

Filters was disabled.
Member

Alex-302 commented Mar 22, 2017

@Mizzick sure.

$websocket,domain=$websocket,domain=news.yandex.ru

image

Filters was disabled.
@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 22, 2017

Contributor

Well it blocks any "raw" resource-type now on Safari. We don't have any option to pick websocket requests.

Contributor

Mizzick commented Mar 22, 2017

Well it blocks any "raw" resource-type now on Safari. We don't have any option to pick websocket requests.

@Mizzick Mizzick closed this Mar 22, 2017

@Mizzick Mizzick added the Wontfix label Mar 22, 2017

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Mar 22, 2017

Member

Is not it better to ignore $websocket in Safari? Existing break the sites.

Member

Alex-302 commented Mar 22, 2017

Is not it better to ignore $websocket in Safari? Existing break the sites.

@Alex-302 Alex-302 reopened this Mar 22, 2017

@Alex-302

This comment has been minimized.

Show comment
Hide comment
@Alex-302

Alex-302 Mar 22, 2017

Member

The problem is not in unblocked websockets.

Member

Alex-302 commented Mar 22, 2017

The problem is not in unblocked websockets.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 23, 2017

Member

Guys, that's EASY.

We should convert $websocket rules to |ws*://

Member

ameshkov commented Mar 23, 2017

Guys, that's EASY.

We should convert $websocket rules to |ws*://

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Mar 23, 2017

Member

Being more precise:

  1. If rule matches ANY URL
    AND
  2. If rule's content type EQUALS to websocket

THEN
|ws*://*

Member

ameshkov commented Mar 23, 2017

Being more precise:

  1. If rule matches ANY URL
    AND
  2. If rule's content type EQUALS to websocket

THEN
|ws*://*

Mizzick added a commit that referenced this issue Mar 24, 2017

Mizzick added a commit that referenced this issue Mar 24, 2017

@Mizzick

This comment has been minimized.

Show comment
Hide comment
@Mizzick

Mizzick Mar 24, 2017

Contributor

Ok, fixed

Contributor

Mizzick commented Mar 24, 2017

Ok, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment