Check content scripts code for the LastPass vulnerability #625 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameshkov
reviewed
Apr 5, 2017
| */ | ||
| var adguardContent = (function () { // jshint ignore:line |
There was a problem hiding this comment.
Why can't we create it in the content-script.js? As I see this file is already used in every content script.
There was a problem hiding this comment.
Because adguardContent variable is just like a marker for common-script.js
...
})(typeof adguard !== 'undefined' ? adguard : adguardContent);
Messaging API implementation (runtimeImpl.onMessage|sendMessage) is exposed into passed variable, and then used in the content-script.js
ameshkov
approved these changes
Apr 5, 2017
| */ | ||
| var adguardContent = (function () { // jshint ignore:line |
# Conflicts: # Extension/lib/content-message-handler.js
adguard
pushed a commit
that referenced
this pull request
Jun 29, 2020
…172 to master * commit 'be6a0112a79f22d59b75012dd15653020eec3d4c': fix:AG-2172 adds wide scriptlets to filtering log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#625