Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tethering/hotspot is falsely detected (MIUI, Zenfone2) #138

Closed
ameshkov opened this issue Oct 26, 2015 · 17 comments
Closed

Tethering/hotspot is falsely detected (MIUI, Zenfone2) #138

ameshkov opened this issue Oct 26, 2015 · 17 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

@ameshkov ameshkov commented Oct 26, 2015

http://4pda.ru/forum/index.php?s=&showtopic=601691&view=findpost&p=43988533

https://www.youtube.com/watch?v=KXmUG37KpAo&feature=youtu.be

From 4pda:

Когда выключаю Передачу данных (на ночь), то Adguard ругался, что я включил Режим модема и фильтрации не будет (причем это уведомление появляется 2 раза подряд, примерно через 15-20 секунд, после выключения передачи данных), утром включаю Передачу данных, и опять выскакивает это уведомление. Вручную захожу в adguard и перезапускаю Защиту.

@ameshkov ameshkov added this to the 2.2 milestone Oct 26, 2015
@bestray92

This comment has been minimized.

Copy link

@bestray92 bestray92 commented Oct 26, 2015

Хочу сделать добавление к этой проблеме, сегодня попробовал включить беспроводной доступ в интернет, посыпались такие же уведомления, только в большем количестве. При отключении Мобильной передачи данных уведомлений было 2 подряд, а при включении/отключении WiFi и мне даже не удалось посчитать Все та же MIUI v7, Adguard, только что обновил (на предыдущем релиз кандидате сначала обнаружил, после обновления баг повторился) https://youtu.be/nV4SpihxkZM

@vbagirov

This comment has been minimized.

Copy link
Member

@vbagirov vbagirov commented Oct 28, 2015

Also happens with WiFi enabling/disabling.

@ameshkov ameshkov changed the title Tethering/hotspot is falsely detected when user disables "Mobile data" Tethering/hotspot is falsely detected when user disables "Mobile data" (MIUI) Nov 3, 2015
@ameshkov ameshkov modified the milestones: 2.5, 3.0 Nov 3, 2015
@justinliao7928

This comment has been minimized.

Copy link

@justinliao7928 justinliao7928 commented Nov 8, 2015

Same bug happened on ASUS Zenfone2 (ZE551ML) with WiFi enabling/disabling.

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Nov 9, 2015

@justinliao7928 hi! could you please collect logs for us to analyze this issue?

The problem is that current stable version does not print enough information to the log file, so you'd better use another build:
http://static.adguard.com/android/release/adguard_issue154.apk

Steps to collect logs:

  1. Install the apk linked above
  2. Reproduce the issue with tethering/hotspot notification
  3. Go to Adguard - Menu - Send Feedback
  4. Post here the ticket ID you'll get in an autoreply email
@justinliao7928

This comment has been minimized.

Copy link

@justinliao7928 justinliao7928 commented Nov 9, 2015

Hello,

Here's the detailed steps that I proceeded.

  1. Uninstall old ADG ( 2.1.267 RC)
  2. Install provided special apk file and enter my key
  3. Reboot to make local VPN filter working
  4. Turn on ADG protection and set log level to "Record Everything"
  5. Reproduce the issue with notification by cycling WiFi toggle or Mobile
    data toggle several times.
    (lots of notifications! lol)
  6. Send feedback (and I received a ticket ID)

*Ticket ID: *CWI-235-88722

Thanks. :)

2015-11-09 21:34 GMT+08:00 Andrey Meshkov notifications@github.com:

@justinliao7928 https://github.com/justinliao7928 hi! could you please
collect logs for us to analyze this issue?

The problem is that current stable version does not print enough
information to the log file, so you'd better use another build:
http://static.adguard.com/android/release/adguard_issue154.apk

Steps to collect logs:

  1. Install the apk linked above
  2. Reproduce the issue with tethering/hotspot notification
  3. Go to Adguard - Menu - Send Feedback
  4. Post here the ticket ID you'll get in an autoreply email


Reply to this email directly or view it on GitHub
#138 (comment)
.

@Bohdan-SUP

This comment has been minimized.

Copy link

@Bohdan-SUP Bohdan-SUP commented Nov 16, 2015

New set of logs in SMT-749-38470 and XPM-444-32611.
And in VIF-863-88548.

@vbagirov

This comment has been minimized.

Copy link
Member

@vbagirov vbagirov commented Nov 20, 2015

More logs: KQD-119-73569

@vbagirov

This comment has been minimized.

Copy link
Member

@vbagirov vbagirov commented Nov 23, 2015

More relevant tickets: WTC-489-23087

@ameshkov ameshkov modified the milestones: 2.1 patch 2, 2.5 Nov 23, 2015
@Bohdan-SUP

This comment has been minimized.

Copy link

@Bohdan-SUP Bohdan-SUP commented Dec 3, 2015

More logs:
XQA-863-55686

@ameshkov ameshkov changed the title Tethering/hotspot is falsely detected when user disables "Mobile data" (MIUI) Tethering/hotspot is falsely detected when user disables "Mobile data" (MIUI, Zenfone2) Dec 9, 2015
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 9, 2015

In case of MIUI the problem is that it always has a USB network interface with IPv4 interface:

usbnet0 (usbnet0) [usbnet0][5][/10.0.2.15] isUp = false

But anyway, we should not detect that because that interface is not active.

@ameshkov ameshkov closed this Dec 9, 2015
@ameshkov ameshkov changed the title Tethering/hotspot is falsely detected when user disables "Mobile data" (MIUI, Zenfone2) Tethering/hotspot is falsely detected (MIUI, Zenfone2) Dec 9, 2015
@vbagirov

This comment has been minimized.

Copy link
Member

@vbagirov vbagirov commented Dec 11, 2015

This user still encounters the same problem even with 2.1.319 version: OFS-517-32825

@vbagirov vbagirov reopened this Dec 11, 2015
@justinliao7928

This comment has been minimized.

Copy link

@justinliao7928 justinliao7928 commented Dec 11, 2015

More log #GWB-888-76064 (Zenfone2)

p_20151212_024105

@vbagirov

This comment has been minimized.

Copy link
Member

@vbagirov vbagirov commented Dec 14, 2015

More logs for Zenfone 2 problem (different user): QLH-799-60348

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 14, 2015

Fixed this.

We should not detect tethering for "usbX" network interfaces.
The only netif we are interested in is "rndis0".

@ameshkov ameshkov closed this Dec 14, 2015
@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 16, 2015

@justinliao7928 could you please check it in the latest beta? Is it good now?

@justinliao7928

This comment has been minimized.

Copy link

@justinliao7928 justinliao7928 commented Dec 17, 2015

Tried new 2.1.338.
It's gooooooood!!!

@ameshkov

This comment has been minimized.

Copy link
Member Author

@ameshkov ameshkov commented Dec 19, 2015

Finally:) Thank you for checking it @justinliao7928 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.