Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale country is not used for initial language detection and not passed to CoreLibs #2651

Closed
sfionov opened this issue Mar 22, 2019 · 2 comments
Assignees
Milestone

Comments

@sfionov
Copy link
Member

sfionov commented Mar 22, 2019

  • Language is detected incorrectly initially in Application and ApplicationService (only "lang" code based on Locale.getLanguage() (without country code) is searched but not "lang-cc", so some languages with country code may not be detected by default).
  • Locale.getLanguage() (without country code) is passed to CoreLibs instead of application language.

Currently it is a problem only for Chinese and Portuguese locales.

@sfionov
Copy link
Member Author

sfionov commented Mar 22, 2019

Related issue is AdguardTeam/CoreLibs#805

@lancelot-moon
Copy link

Confirmed while Android system language is Traditional Chinese (繁體中文, locale: zh-TW).
This is fixed in v3.0.344η.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants